Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] [exporter/s3exporter] aws s3 exporter initial version (First PR, config + exporter stub) #9979

Merged
merged 15 commits into from
Apr 3, 2023
Merged

[chore] [exporter/s3exporter] aws s3 exporter initial version (First PR, config + exporter stub) #9979

merged 15 commits into from
Apr 3, 2023

Conversation

pdelewski
Copy link
Member

@pdelewski pdelewski commented May 12, 2022 •
edited
Loading

Description:
awss3exporter exports logs and traces
Link to tracking Issue:
#2835
Testing:
Unit tests covering exporter code
Documentation:
Readme describing exporter functionality and configuration.

@pdelewski pdelewski requested review from a team and dmitryax May 12, 2022 10:13
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 12, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pdelewski / name: Przemyslaw Delewski (b0a713f)

@pdelewski pdelewski changed the title aws s3 exporter initial version aws s3 exporter initial version (First PR, config + exporter stub) May 12, 2022
@pdelewski pdelewski closed this May 20, 2022
@pdelewski pdelewski reopened this May 20, 2022
@pdelewski pdelewski force-pushed the s3exporter-1 branch 2 times, most recently from cb509b6 to ecd7a7c Compare June 1, 2022 09:30
@pdelewski pdelewski force-pushed the s3exporter-1 branch 4 times, most recently from 463602b to 213199e Compare June 7, 2022 07:37
@pdelewski pdelewski force-pushed the s3exporter-1 branch 3 times, most recently from 58bd38d to 9d4fad5 Compare June 7, 2022 12:58
@djaglowski
Copy link
Member

@pmm-sumo this appears ready for another review

@pdelewski
Copy link
Member Author

@dmitryax Could you look at this PR?

@pdelewski
Copy link
Member Author

pdelewski commented Jun 30, 2022 •
edited
Loading

@djaglowski @open-telemetry/collector-contrib-maintainers could you take a look?

@pdelewski pdelewski changed the title aws s3 exporter initial version (First PR, config + exporter stub) [chore] [exporter/s3exporter] aws s3 exporter initial version (First PR, config + exporter stub) Mar 13, 2023
@pdelewski
Copy link
Member Author

@atoulme I updated PR

atoulme
atoulme reviewed Mar 20, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
atoulme
atoulme approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bring it in

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Mar 30, 2023
@atoulme atoulme mentioned this pull request Mar 30, 2023
Closed
mx-psi
mx-psi requested changes Apr 3, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
exporter/awss3exporter/go.mod Outdated Show resolved Hide resolved
@mx-psi mx-psi removed the ready to merge Code review completed; ready to merge by maintainers label Apr 3, 2023
@mx-psi
Copy link
Member

mx-psi commented Apr 3, 2023

Almost there! This just needs a couple of small changes to make this aligned with the current Collector Go version and changelog practices.

mx-psi
mx-psi reviewed Apr 3, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@pdelewski pdelewski requested a review from mx-psi April 3, 2023 10:46
@mx-psi mx-psi merged commit a87e869 into open-telemetry:main Apr 3, 2023
@github-actions github-actions bot added this to the next release milestone Apr 3, 2023
@pdelewski pdelewski mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@pmm-sumo pmm-sumo pmm-sumo approved these changes

@mx-psi mx-psi mx-psi approved these changes

@atoulme atoulme atoulme approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@bogdandrutu bogdandrutu

Labels
Accepted Component New component has been sponsored
Projects
None yet
Milestone
v0.75.0
Development

Successfully merging this pull request may close these issues.
9 participants
@pdelewski @djaglowski @anarwal @perk-sumo @atoulme @mx-psi @codeboten @pmm-sumo @bogdandrutu